SHARD-44: GlobalTx fixes #103
Open
+286
−200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/Data/Collector.ts
Outdated
| @@ -73,6 +73,11 @@ | |||
| executionGroupNodes: ConsensusNodeInfo[], | |||
| minConfirmations: number = config.RECEIPT_CONFIRMATIONS | |||
| ): Promise<{ success: boolean; newReceipt?: Receipt.ArchiverReceipt }> => { | |||
| // If robustQuery is disabled, do offline verification | |||
| if (!config.useRobustQueryForReceipt) { | |||
Check failure
Code scanning / CodeQL
User-controlled bypass of security check High
S0naliThakur
force-pushed
the
globalTx-fixes
branch
2 times, most recently
from
793f574 to
c131ed4
Compare
S0naliThakur
requested review from
jintukumardas,
abdulazeem-tk4vr and
aniketdivekar
S0naliThakur
force-pushed
the
globalTx-fixes
branch
2 times, most recently
from
f29133e to
cf6a9e3
Compare
| if (nestedCountersInstance) | ||
| nestedCountersInstance.countEvent( | ||
| 'receipt', | ||
| 'Invalid_receipt_globalModification_valid_signs_count_less_than_votingGroupCount' |
Check failure
Code scanning / CodeQL
User-controlled bypass of security check High
S0naliThakur
force-pushed
the
globalTx-fixes
branch
from
56d1083 to
832bdec
Compare
devendra-shardeum
previously approved these changes
Dec 13, 2024
aniketdivekar
previously approved these changes
Dec 13, 2024
…loadReceipt, improved error logs, deprecated setupWorkerProcesses and offloadReceipt.
S0naliThakur
force-pushed
the
globalTx-fixes
branch
from
82ce0d0 to
780ed88
Compare
S0naliThakur
dismissed stale reviews from aniketdivekar and devendra-shardeum
The base branch was changed.
|
@S0naliThakur Since we have disabled the workers. We can also comment out the code where we are initializing and setting up the worker process. Please refer to these lines - CC: @aniketdivekar |
jintukumardas
requested changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear: https://linear.app/shm/issue/SHARD-44/globaltx-validation
Summary: Implement global receipt validation and enhance receipt verification logic
useRobustQueryForReceiptflagstoreReceiptmethod to useverifyArchiverReceiptdirectly.verifyGlobalTxreceiptOfflineandverifyReceiptMajorityfor better code readability.